Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing permissions to typings #302

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Add missing permissions to typings #302

merged 5 commits into from
Nov 29, 2023

Conversation

lkostrowski
Copy link
Member

@lkostrowski lkostrowski commented Nov 17, 2023 •
edited
Loading

Updates missing sync events types and responses definitions

  • Check with core source code missing pieces

@lkostrowski lkostrowski requested a review from a team November 17, 2023 08:56
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: d79a9a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@saleor/app-sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20231117085632

Install it with

pnpm add @saleor/[email protected]

@lkostrowski lkostrowski linked an issue Nov 17, 2023 that may be closed by this pull request
Type '"MANAGE_ORDERS_IMPORT"' is not assignable to type 'AppPermission'.t #301
Closed
@lkostrowski lkostrowski force-pushed the add-missing-permission-MANAGE_ORDERS_IMPORT branch from ac60ca8 to 0a68a90 Compare November 17, 2023 08:57
@github-actions GitHub Actions
Copy link
Contributor

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20231117085805

Install it with

pnpm add @saleor/[email protected]

@lkostrowski lkostrowski linked an issue Nov 17, 2023 that may be closed by this pull request
types wrong: sync events #247
Closed
@lkostrowski lkostrowski changed the title Add MANAGE_ORDERS_IMPORT permission to types Add missing permissions to typings Nov 17, 2023
@github-actions GitHub Actions
Copy link
Contributor

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20231118094638

Install it with

pnpm add @saleor/[email protected]

@lkostrowski lkostrowski marked this pull request as draft November 18, 2023 10:03
lkostrowski
lkostrowski commented Nov 29, 2023
View reviewed changes
src/handlers/next/saleor-webhooks/sync-webhook-response-builder.ts Outdated
id: string;
supportedPaymentFlows: Array<"INTERACTIVE">; // todo confirm
type: string;
// todo confirm which are optional, also numbers vs strings
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its fine

@github-actions GitHub Actions
Copy link
Contributor

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20231129144447

Install it with

pnpm add @saleor/[email protected]

@lkostrowski lkostrowski force-pushed the add-missing-permission-MANAGE_ORDERS_IMPORT branch from 77380d7 to d79a9a6 Compare November 29, 2023 14:50
@lkostrowski lkostrowski marked this pull request as ready for review November 29, 2023 14:50
@github-actions GitHub Actions
Copy link
Contributor

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20231129145109

Install it with

pnpm add @saleor/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

Package Line Rate Branch Rate Complexity Health
src 83% 95% 0 ✔
src.APL 85% 85% 0 ✔
src.APL.saleor-cloud 73% 80% 0 ➖
src.app-bridge 88% 86% 0 ✔
src.handlers.next 90% 84% 0 ✔
src.handlers.next.saleor-webhooks 93% 82% 0 ✔
src.middleware 60% 97% 0 ➖
src.settings-manager 96% 89% 0 ✔
src.test-utils 100% 90% 0 ✔
src.util 76% 100% 0 ✔
Summary 85% (3381 / 3973) 87% (404 / 463) 0 ✔

witoszekdev
witoszekdev approved these changes Nov 29, 2023
View reviewed changes
package.json
@@ -64,7 +64,7 @@
"react-dom": "18.2.0",
"tsm": "^2.2.2",
"tsup": "^6.2.3",
"typescript": "^4.9.5",
"typescript": "4.9.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to pin TypeScript version only or other dependencies as well?

Copy link
Member Author

@lkostrowski lkostrowski Nov 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should pin everything. I will do that in next PRs - it will require additional testing to ensure everything stays in place (and will add "save exact" flag for project level)

@lkostrowski lkostrowski merged commit 3c68c4c into main Nov 29, 2023
5 checks passed
@lkostrowski lkostrowski deleted the add-missing-permission-MANAGE_ORDERS_IMPORT branch November 29, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@witoszekdev witoszekdev witoszekdev approved these changes

Assignees

@lkostrowski lkostrowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type '"MANAGE_ORDERS_IMPORT"' is not assignable to type 'AppPermission'.t types wrong: sync events
2 participants
@lkostrowski @witoszekdev